Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent possible segm violation in TopSingleLeptonHLTOfflineDQM #2401

Merged

Conversation

perrotta
Copy link
Contributor

Prevent possible segm violation in DQMOffline.Trigger.TopSingleLeptonHLTOfflineDQM

The code is quite convoluted, and certainlly something better can be done.
However, by just allowing for jets the same kind of check on the vector boundary as it is done a few lines above for electrons and muons one can prevent a segmentation violation when the jet selector remove all jets from the vector correctedJets

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_1_X.

Prevent possible segm violation in TopSingleLeptonHLTOfflineDQM

It involves the following packages:

DQMOffline/Trigger

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2401/132/summary.html

@perrotta
Copy link
Contributor Author

It looks like having nothing to do with the content of the pull request:

filesFromList
raise Exception("There are not files in input from the file list")
Exception: There are not files in input from the file list

A.

cmsbuild notifications@github.com ha scritto:

-1
When I ran the RelVals I found an error in the following worklfows:
1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2401/132/summary.html


Reply to this email directly or view it on GitHub:
#2401 (comment)


This message was sent using IMP, the Internet Messaging Program.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Feb 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 13, 2014
DQMOffline/Trigger -- Prevent possible segm violation in TopSingleLeptonHLTOfflineDQM
@nclopezo nclopezo merged commit 3cb2396 into cms-sw:CMSSW_7_1_X Feb 13, 2014
@perrotta perrotta deleted the fixTopSingleLeptonHLTOfflineDQM branch February 18, 2014 11:32
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Oracle environment removal and Oracle related packages update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants