Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying Hcal Conditions via the CondDB Browser #24084

Merged
merged 27 commits into from Sep 20, 2018

Conversation

jjackson12
Copy link
Contributor

Adding Hcal Conditions to the Conditions Database web browser interface (cms-conddb.cern.ch). Partially functional state ready to test on web browser.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24084/5768

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24084/5768/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24084/5768/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2018

Pull request #24084 was updated. @arunhep, @tocheng, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please check and sign again.

@pohsun
Copy link

pohsun commented Sep 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30306/console Started: 2018/09/09 21:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24084/30306/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3144023
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143823
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Sep 18, 2018

+1

@lpernie
Copy link
Contributor

lpernie commented Sep 18, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@deguio @jjackson12 @pohsun @ggovi could you please clarify where this code is really exercised?
Is this code used in the test workflows? I doubt, but please correct me in case

@deguio
Copy link
Contributor

deguio commented Sep 19, 2018

ciao fabio,
the code runs in the demo version of the payload inspector already:
https://cms-conddb.cern.ch/cmsDbBrowser/payload_inspector/Prod/DEMO

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 462b72e into cms-sw:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants