Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MuonIDFilterProducerForHLT (10_2) #24129

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Jul 30, 2018

Fix for MuonIDFilterProducerForHLT (10_2)
Needed for ConfDB parsing

@Martin-Grunewald
Copy link
Contributor Author

backport of #24130

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_2_X.

It involves the following packages:

RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29561/console Started: 2018/07/30 16:10

@Martin-Grunewald
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24129/29561/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892884
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892692
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 1, 2018

+1

for #24129 47a2876

  • the implementation is in line with the description/purpose. MuonIDFilterProducerForHLT is currently not used in the release and there is no default config. The change will only add a new generated config file.
    • the "backport" is correct: the same topic branch is used here as for the master branch
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Aug 1, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Aug 2, 2018

+1

@cmsbuild cmsbuild merged commit 442461d into cms-sw:CMSSW_10_2_X Aug 2, 2018
@Martin-Grunewald Martin-Grunewald deleted the FixMuonIDFilterProducerForHLT branch November 17, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants