Fix dereference of PVOrig (94X)

[gpetruc]

Addressing https://its.cern.ch/jira/browse/CMSCOMPPR-3271

@arizzi

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix dereference of PVOrig (master) #24138

[gpetruc]

backport of #24138

[gpetruc]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29581/console Started: 2018/07/31 14:15

[cmsbuild]

+1
Tested at: e07b10e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24137/29581/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24137/29581/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 102
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721229
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[slava77]

+1

for #24137 e07b10e

• this is a rather trivial fix, adding a check for PVOrig.isNonnull() before dereferencing it. It should affect only previously crashing events.
  • the "backport" is correct: changes are the same as in Fix dereference of PVOrig (master) #24138 5317f93
• jenkins tests pass
• I'm relying on tests done by @gpetruc in connection with https://its.cern.ch/jira/browse/CMSCOMPPR-3271 to confirm the problem resolution

[fabiocos]

+1

[fabiocos]

merge