Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding NANO step to 2018 MC workflows (102X) #24161

Merged

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Aug 1, 2018

This PR adds a NANO step to all 2018 MC workflows in 102X (with the exceptions of the special workflows which do not produce MINIAODSIM output)

backport of #24141

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

A new Pull Request was created by @fabozzi for CMSSW_10_2_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @kpedro88, @fabozzi, @pgunnell, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor Author

fabozzi commented Aug 1, 2018

backport of #24141

@fabozzi
Copy link
Contributor Author

fabozzi commented Aug 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29612/console Started: 2018/08/01 17:56

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24161/29612/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2665422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2665238
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 123 log files, 14 edm output root files, 31 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented Aug 2, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

+1

@cmsbuild cmsbuild merged commit cb81278 into cms-sw:CMSSW_10_2_X Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants