Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LHCInfo O2O #24187

Merged
merged 1 commit into from Aug 17, 2018
Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Aug 3, 2018

Fix for handling properly the start/end of O2O job

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

A new Pull Request was created by @ggovi for CMSSW_10_2_X.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Aug 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29638/console Started: 2018/08/03 12:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24187/29638/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892884
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892692
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Aug 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd83052 into cms-sw:CMSSW_10_2_X Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants