Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From cmssw 7 1 0 pre2 skip bad files and matrix dqmio #2422

Conversation

franzoni
Copy link

  • skipBadFiles flag implemented. Needed to use the DQMIO in production. includes skipBadFiles flag implemented #2404 from Deguio
  • change to the validation matrix to deploy DQMIO in production; this has no impact on the IB's, only on worfklows submissions

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni for CMSSW_7_1_X.

From cmssw 7 1 0 pre2 skip bad files and matrix dqmio

It involves the following packages:

Configuration/PyReleaseValidation
DQMServices/FwkIO

@ojeda, @vlimant, @danduggan, @rovere, @cmsbuild, @franzoni, @nclopezo, @deguio, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

@franzoni
Hi Giovanni,
This pull request is not mergeable, could you please rebase it?

@franzoni
Copy link
Author

Hi David, I have a hard time to understand why that is so...
But sure, will do.
Should this PR be closed and a brand new be remade ?
Cheers, G.

On 12 February 2014 14:00, David Mendez notifications@github.com wrote:

@franzoni https://github.com/franzoni
Hi Giovanni,
This pull request is not mergeable, could you please rebase it?

Reply to this email directly or view it on GitHubhttps://github.com//pull/2422#issuecomment-34866179
.

@nclopezo
Copy link
Contributor

Hi Giovanni,

If you rebase the branch and push it again it should be ok, you don't need to create a new one.

@franzoni
Copy link
Author

+1
tested on workflows 4.25,29,5.1,7,1308,1306

@cmsbuild
Copy link
Contributor

Pull request #2422 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Feb 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 13, 2014
…iles_and_matrixDQMIO

DQM fixes -- From cmssw 7 1 0 pre2 skip bad files and matrix dqmio
@ktf ktf merged commit 1bbaece into cms-sw:CMSSW_7_1_X Feb 13, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #2422 was updated. @vanbesien, @dmitrijus, @cmsbuild, @srimanob, @fabozzi, @hengne, @davidlange6 can you please check and sign again.

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants