Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang warnings L1Trigger/L1TMuonEndCap #24222

Merged

Conversation

Dr15Jones
Copy link
Contributor

modified code to avoid clang compiler warnings.

The member functions in PtAssignmentEngine were only calling
themselves which would result in infinite recursion. Instead, those
virtual functions were made into '=0' to require overrides (which
already existed in all cases).
The three file static arrays are never used in the file.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29698/console Started: 2018/08/06 23:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24222/29698/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891565
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891374
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor

thomreis commented Aug 7, 2018

@abrinke1 please take a look at this.

@abrinke1
Copy link
Contributor

abrinke1 commented Aug 7, 2018

Hi @Dr15Jones ,
Can you specify exactly the errors are that you are seeing in the compiler? Two of the functions you deleted are critical to the EMTF emulator:
scale_pt : http://cmslxr.fnal.gov/source/L1Trigger/L1TMuonEndCap/src/PtAssignment.cc?v=CMSSW_10_2_1#0082
unscale_pt : http://cmslxr.fnal.gov/source/L1Trigger/L1TMuonEndCap/src/PtAssignmentEngine.cc?v=CMSSW_10_2_1#0147

It looks like the dPhiNLBMap arrays you deleted were unused, so it's fine to delete those. @jiafulow will also want to follow this conversation.

Best,
Andrew

@Dr15Jones
Copy link
Contributor Author

@abrinke1 I didn't actually delete the functions, instead I said that those virtual functions must be defined in any inheriting class. As for the warnings, you can see them here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_10_3_CLANG_X_2018-08-06-2300/L1Trigger/L1TMuonEndCap

@abrinke1
Copy link
Contributor

abrinke1 commented Aug 7, 2018

Hi @Dr15Jones ,
Sorry about that. Discussing with @jiafulow , he confirms that your changes should make no difference to how the emulator runs. So this looks fine to me.
Best,
Andrew

@thomreis
Copy link
Contributor

thomreis commented Aug 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2018

+1

@cmsbuild cmsbuild merged commit 7ede798 into cms-sw:master Aug 8, 2018
@Dr15Jones Dr15Jones deleted the clangWarningsL1TriggerL1TMuonEndCap branch August 31, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants