New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang warnings L1Trigger/L1TMuonEndCap #24222
Clang warnings L1Trigger/L1TMuonEndCap #24222
Conversation
The member functions in PtAssignmentEngine were only calling themselves which would result in infinite recursion. Instead, those virtual functions were made into '=0' to require overrides (which already existed in all cases).
The three file static arrays are never used in the file.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24222/5916 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: L1Trigger/L1TMuonEndCap @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@abrinke1 please take a look at this. |
Hi @Dr15Jones , It looks like the dPhiNLBMap arrays you deleted were unused, so it's fine to delete those. @jiafulow will also want to follow this conversation. Best, |
@abrinke1 I didn't actually delete the functions, instead I said that those virtual functions must be defined in any inheriting class. As for the warnings, you can see them here: |
Hi @Dr15Jones , |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
modified code to avoid clang compiler warnings.