New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF fix track address for low-quality tracks #24234
Conversation
Single-LCT tracks in cosmic mode always have quality = 0 : https://tinyurl.com/y9nejzvp This line causing EMTF output vs. uGMT input mismatches for tracks with 1 <= quality < 4 : https://tinyurl.com/yacqb3nm In particular, mismatch in track address 8 (kTrkNum, track_num) : https://tinyurl.com/y7buhfk7, https://tinyurl.com/ycpesl34 Fix should significantly reduce track address disagreement : https://tinyurl.com/ybmblbdz
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24234/5939 |
A new Pull Request was created by @abrinke1 for master. It involves the following packages: EventFilter/L1TRawToDigi @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Single-LCT tracks in cosmic mode always have quality = 0 : https://tinyurl.com/y9nejzvp
This line causing EMTF output vs. uGMT input mismatches for tracks with 1 <= quality < 4 : https://tinyurl.com/yacqb3nm
In particular, mismatch in track address 8 (kTrkNum, track_num) : https://tinyurl.com/y7buhfk7, https://tinyurl.com/ycpesl34
Fix should significantly reduce track address disagreement : https://tinyurl.com/ybmblbdz