Change how we calculate GUID #24246
Change how we calculate GUID #24246
Conversation
Previously, we used uuid_generate_time which used the MAC address of the machine as part of the calculation. This is leading to problems when we run on virtual machines as many of the machines share the same dummy MAC address. This has lead to noticeable GUID collisions in production. By switching to uuid_generate_random, we hope to decrease collisions.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24246/5952 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: 18feb1f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Previously, we used uuid_generate_time which used the MAC address of the machine as part of the calculation. This is leading to problems when we run on virtual machines as many of the machines share the same dummy MAC address. This has lead to noticeable GUID collisions in production. By switching to uuid_generate_random, we hope to decrease collisions.