New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL trigger] make code compatible with V9 geometry #24256
[HGCAL trigger] make code compatible with V9 geometry #24256
Conversation
Preliminary V9 geometry implementation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24256/5963 |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jbsauvan there are errors in the D28 workflow in the IB:
|
Hi @kpedro88, |
Thanks |
This is a first implementation which has minimal changes outside the geometry modules.
In particular, the same
HGCalDetId
are kept for trigger cells for the moment; the new detids are not used for trigger cells yet.Although this implementation doesn't use all the functionalities of the new detids and geometry utilities, it allows a smooth transition between the V8 and V9 geometries, since the core of the code remains the same, and one can switch from one to the other rather transparently.
Other iterations are expected in the future.
One thing has been changed outside the L1THGCal package: the
HGCScintillatorDetId
andHGCSiliconDetId
masking constants have been made public to be able to access them. An alternative solution would be to copy these constants in the trigger code if these constants shouldn't be public.The HGCAL trigger sequence has been put back in the
phase2_hgcalV9
era.Depends on external cms-data/L1Trigger-L1THGCal#9