Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL trigger] make code compatible with V9 geometry #24256

Merged
merged 29 commits into from Aug 28, 2018

Conversation

jbsauvan
Copy link
Contributor

@jbsauvan jbsauvan commented Aug 9, 2018

This is a first implementation which has minimal changes outside the geometry modules.
In particular, the same HGCalDetId are kept for trigger cells for the moment; the new detids are not used for trigger cells yet.
Although this implementation doesn't use all the functionalities of the new detids and geometry utilities, it allows a smooth transition between the V8 and V9 geometries, since the core of the code remains the same, and one can switch from one to the other rather transparently.
Other iterations are expected in the future.

One thing has been changed outside the L1THGCal package: the HGCScintillatorDetId and HGCSiliconDetId masking constants have been made public to be able to access them. An alternative solution would be to copy these constants in the trigger code if these constants shouldn't be public.

The HGCAL trigger sequence has been put back in the phase2_hgcalV9 era.

Depends on external cms-data/L1Trigger-L1THGCal#9

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2018

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24256/29941/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2983602
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2983411
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@kpedro88
Copy link
Contributor

@civanch, @nsmith-, @rekovic, @thomreis please check and sign

@civanch
Copy link
Contributor

civanch commented Aug 24, 2018

+1

@kpedro88
Copy link
Contributor

@nsmith-, @rekovic, @thomreis please check and sign

@rekovic
Copy link
Contributor

rekovic commented Aug 28, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

@jbsauvan there are errors in the D28 workflow in the IB:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_10_3_X_2018-08-29-1600/pyRelValMatrixLogs/run/24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28.log

----- Begin Fatal Exception 29-Aug-2018 21:53:41 CEST-----------------------
An exception of category 'BadGeometry' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 1
   [1] Running path 'L1simulation_step'
   [2] Calling method for module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
Exception Message:
HGCalTriggerGeometry: scintillator cell ieta=1, iphi=11 is not mapped to any trigger cell. The trigger cell mapping should be modified.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 29-Aug-2018 21:53:41 CEST-----------------------
An exception of category 'BadGeometry' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 5 stream: 0
   [1] Running path 'L1simulation_step'
   [2] Calling method for module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
Exception Message:
HGCalTriggerGeometry: scintillator cell ieta=48, iphi=174 is not mapped to any trigger cell. The trigger cell mapping should be modified.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 29-Aug-2018 21:53:41 CEST-----------------------
An exception of category 'BadGeometry' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 2
   [1] Running path 'L1simulation_step'
   [2] Calling method for module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
Exception Message:
HGCalTriggerGeometry: scintillator cell ieta=48, iphi=96 is not mapped to any trigger cell. The trigger cell mapping should be modified.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 29-Aug-2018 21:53:41 CEST-----------------------
An exception of category 'BadGeometry' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 3
   [1] Running path 'L1simulation_step'
   [2] Calling method for module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
Exception Message:
HGCalTriggerGeometry: scintillator cell ieta=47, iphi=226 is not mapped to any trigger cell. The trigger cell mapping should be modified.
----- End Fatal Exception -------------------------------------------------

@jbsauvan
Copy link
Contributor Author

Hi @kpedro88,
The HGCAL scintillator geometry has probably been changed. The best would probably to remove again the HGCAL trigger from the V9 workflows, until the geometry converges.

@kpedro88
Copy link
Contributor

@bsunanda were there cells added in the scintillator geom?
@jbsauvan I'll make a quick PR to remove HGCal L1 again for now

@jbsauvan
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants