New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change produce function return type to unique_ptr in CondTools L1Trigger #24265
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24265/5979 |
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: CondTools/L1Trigger @ggovi, @rekovic, @cmsbuild, @thomreis, @nsmith- can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
merge @ggovi it looks the simple completion of a move signed by you several months ago |
looks like this was overlooked in PR #22138, although it should not actually affect anything currently (these changes are in preparation for future concurrent IOV processing)