Major updates to L3 Muon OI SeedGenerator for high efficiency

[bmahakud]

• The fixes added is supposed to enhance the L3 Outside-in reconstruction efficiency up to 3-4% depending on eta region

  • link to slides in HLT meeting :
    https://indico.cern.ch/event/744577/contributions/3076786/attachments/1688167/2715423/L3_OI_improvements_Purdue.pdf
  • link to the slides in TSG meeting
    https://indico.cern.ch/event/746298/contributions/3086154/attachments/1693133/2724601/OI_improvementsPurdue25thJuly_Final.pdf

• Currently OI starts from L2 muons with

  • Trajectory State on Surface (TSOS)TSOS at outer tracker surface from L2 after updated with IP information (State-1)
  • TSOS on the outer tracker surface from L2(State-2)

• Fix-I

  • In the current configuration seeds are created starting from both states (State-1, State-2) for almost all muons
  • In the new setup seeds are created
    • Mostly from State-1 (one updated with IP)
    • Both states are used only if
      • L2 muon valid hits < 20 (for eta <2.1)
      • L2 muon valid hits <30 (for eta >2.1)

• Fix-II

  • In the current configuration 'PropagatorWithMaterial' is used to propagate from muon station to outer tracker surface (outside tracker volume) for seeding
  • Now using 'SteppingHelixPropagator' outside the tracker volume for seeding
  • Now using 'PropagatorWithMaterialParabolicMf' inside the tracker volume instead of 'PropagatorWithMaterial' for seeding

• Fix-III

  • Seeds set the initial conditions for track fitting after trajectory building
  • In current Seed in the trajectory is created in the seed generator.
  • Now the seed created based on the last measurement at the end of pattern recognition sets the initial condition for track fitting

• Fix-IV

  • Scale factors are used to inflate the TSOSs errors so that the window of hit search gets widened
  • Scale factors are calculated dynamically for optimizing efficiency

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24267/5983

[cmsbuild]

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for master.

It involves the following packages:

HLTrigger/Configuration
RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@echapon, @battibass, @makortel, @abbiendi, @jhgoh, @Martin-Grunewald, @bellan, @HuguesBrun, @folguera, @calderona, @trocino, @geoff-smith, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24267/5989

[cmsbuild]

Pull request #24267 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29788/console Started: 2018/08/13 06:37

[Martin-Grunewald]

@bmahakud
You need to revert the changes from #23988 to put back the original TSGFromOI there!

[cmsbuild]

+1
Tested at: 35a5888
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24267/29788/summary.html

[cmsbuild]

+1
Tested at: 89cf4b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24267/29870/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
747143c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24267/29870/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24267/29870/git-merge-result

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24267/29870/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891469
• DQMHistoTests: Total failures: 1263
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2890016
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[perrotta]

+1

• The same code changes that were implemented with the reverted Fixes to L3 Muon OI SeedGenerator (TSGForOI) for high efficiency  #23988 are put here in a dedicated plugin
• No effect on offline reco quantities, as expected, this being only used in HLT

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Martin-Grunewald]

@bmahakud
This PR seems to create a crash in the trigger path: HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v3,
namely:

----- Begin Fatal Exception 20-Aug-2018 08:47:01 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 3 event: 144 stream: 1
   [1] Running path 'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v3'
   [2] Calling method for module TSGForOIFromL2/'hltIterL3OISeedsFromL2MuonsOpenMu'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: hltL2Muons
Looking for productInstanceName: UpdatedAtVtx

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

This happens when we test one path at a time. Either this path should not update the plugin, or the module/sequence to generate the requested collection is missing.

Please have a look and fix asap.

[Martin-Grunewald]

I believe one has to add in the customisation:

  process.hltIterL3OISeedsFromL2MuonsOpenMu.src = cms.InputTag( 'hltL2MuonsOpenMu','UpdatedAtVtx' )

Please check and confirm. I'll make a PR!

[Martin-Grunewald]

@bmahakud
Fixed for 103X in #24342.
If correct, this (or another fix) must be added to the backport PRs #24323 and #24324, please do so asap. Thanks!

[bmahakud]

@Martin-Grunewald
Thanks for the fixing
process.hltIterL3OISeedsFromL2MuonsOpenMu.src = cms.InputTag( 'hltL2MuonsOpenMu','UpdatedAtVtx' )

In back ports there is no update in configuration and is they are to be used in old configuration then it should work. Because old configuration will have correct arguments.

[Martin-Grunewald]

Ah yes, correct!