Responding to PR 24183 (Updating gridpacks for GEN related Rel-Val failures) #24268
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24268/5984 |
|
A new Pull Request was created by @Saptaparna (Saptaparna Bhattacharya) for master. It involves the following packages: Configuration/Generator @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 562.0, 25210.0, 1360.0 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 7bd2ba3 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@alberto-sanchez Indeed, I also see the problem when testing interactively. The problem is with the ttbar gridpack and hence affects workflows 25210.0 and 1360.0. Updating the gridpack to an ever more recent one (MG5 260) seems to solve the problem. Running local tests now. |
|
please test workflow 562.0, 25210.0, 1360.0 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@alberto-sanchez Does this mean the PR can be merged? |
|
Dear @Saptaparna , please make an explicit title an better explanation,- we can't guess from this title if you are talking about HCAL , Tracker, Trigger, Generator, and what you changed .... Thank you |
|
@boudoul This PR is a response to some requests in #24183 and refers to workflows 562.0, 25210.0, 1360.0 that failed at the generator step. The problem was due to the presence of old gridpacks. The paths of the gridpacks have been updated and based on the last code check do not lead to crashes during Rel-Val production. |
|
I know , but we can't guess from the title 'Responding to PR 24183', if you are talking about HCAL , Tracker, Trigger, Generator . The title of PRS are very important because intensively used by validators (for example) or to easily keep track of what is entering in a given release: it is what will appear in the release notes and we should know what is the topic of a PR by just reading it . So please edit the title [you can keep 'Responding to PR 24183' if you want in it] but please add something more explicit in addition- The edit button is next to the title |
Saptaparna
changed the title
|
+1 |
|
errors went away |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@Saptaparna for my understanding, how do these gridpacks solve the problem, without specification of another environment? Are they simply produced with more recent CMSSW versions? |
|
@Saptaparna hmm, not really looking at the name: BulkGraviton_ZZ_inclu_narrow_M1200_slc6_amd64_gcc481_CMSSW_7_1_30_tarball |
|
@Saptaparna @alberto-sanchez could you please clarify how these new gridpacks are solving the problem? I am pleased of the solution of the issue, but I would like to understand the sgtrategy behind. At some point we will need to discuss a global strategy valid in general |
|
@fabiocos Apologies for the slow response. The problematic gridpacks were the ones that did not include some of the new features in the runcmsgrid script (https://github.com/cms-sw/genproductions/blob/master/bin/MadGraph5_aMCatNLO/runcmsgrid_LO.sh#L20ToL42). The updated gridpacks were produced with newer versions of MadGraph (2.2.2 vs 2.4.2) and a new version for script referred to above. One thing to note is that even with MadGraph 2.4.2, the ttbar workflow repeatedly failed (investigating as why this happened, possibly that gridpack was corrupted for some reason). Updating the ttbar workflow to a MG5 2.6.0 gridpack fixed the problem. It maybe worth digging deeper to understand what worked in 260 that didn't work in 242. However, given the recent push to upgrade genproductions to 260 (branch 260 has existed for many months, but now 260 will be upgraded to master) in general may mean that soon 242 gridpacks may have only limited use. |
|
+1 |
Updated to CMSSW master and includes my changes.