Puppi pileupjetID

[knash]

Update to pileupjetID algorithm to include an option to calculate the discriminator variables using Puppi weights.

There are a few effects, but one visible change is the fractional pt variables. previously these were calculated using the Puppi jet pt in the denominator and and the unweighted constituent sum in the numerator which leads to an undesirable >1 tail in the total pt fraction. See below

OFF

ON

There was no additional implementation beyond the feature addition (ie no standard workflows should change).

I think the changes in RecoJets/JetProducers/src/PileupJetIdAlgo.cc, Line 509-510 are appropriate but would like a second opinion @ahinzmann .

This was tested only using a modified version of the script:
RecoJets/JetProducers/test/testJetTools_onMiniAOD_cfg.py
There were a few small changes required for this script to run in 10_3_X which I am also pushing.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24287/6020

[cmsbuild]

A new Pull Request was created by @knash for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @rappoccio, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29825/console Started: 2018/08/14 22:36

[cmsbuild]

+1
Tested at: 1afcc6b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24287/29825/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24287/29825/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891469
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891277
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

Pull request #24287 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[ahinzmann]

What is the purpose of this line? PdgId 1,2 seem not to be used in PF? https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideParticleFlow#Particle_types

[knash]

These are HF had/gamma. The multNeut should reproduce patjet->neutralMultiplicity() exactly in the case that usePuppi is False.

So we have events like this (setting usePuppi to False)

Adding 130
Adding 130
Adding 22
Adding 22
Adding 22
Adding 22
Adding 22
Adding 22
multNeut = 8 ; patjet->neutralMultiplicity() = 8

and events like this

Adding 1
Adding 1
Adding 1
Adding 1
Adding 1
multNeut = 5 ; patjet->neutralMultiplicity() = 5

[ahinzmann]

ok makes sense!

[perrotta]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29880/console Started: 2018/08/16 15:42

[cmsbuild]

+1
Tested at: e5fdda6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24287/29880/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24287/29880/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2983602
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2983404
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #24287 e5fdda6

• code changes are in line with the PR description; current defaults are unchanged
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1