Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu V3.4 #24302

Merged
merged 1 commit into from Aug 16, 2018
Merged

HLT menu V3.4 #24302

merged 1 commit into from Aug 16, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

HLT menu V3.4
Based on CMSSW_10_3_X_2018-08-14-2300

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29852/console Started: 2018/08/15 18:51

@Dr15Jones
Copy link
Contributor

+1
for Utilities/ReleaseScripts/scripts/addOnTests.py

@Martin-Grunewald
Copy link
Contributor Author

please test

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Thanks!!

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24302/29852/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891277
  • DQMHistoTests: Total failures: 73
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891014
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.252 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.85,... ): 1.084 KiB HLT/GeneralHLTOffline
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@Martin-Grunewald I understand that TSG is not interested in keeping the previous frozen menu in 10_3_X. This is relevant in 10_2_X of course, I just would like to understand the rationale behind this replacement in 10_3_X

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
This is only for 10_3, no change in 10_2. We'd like to have the most recent one in 10_3 as long as 10_3 is still not frozen for such changes. With this we profit from (relval) validation in 10_3 pre releases.

@fabiocos
Copy link
Contributor

@Martin-Grunewald sure, I was just wondering about the choice to keep only the newest one and not the older. I may guess this is for simplicity of maintenance, and that there is no interest in the 10_2_X frozen version

@fabiocos
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor Author

Indeed!

@cmsbuild cmsbuild merged commit 0858091 into cms-sw:master Aug 16, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLT_V3p4_103X branch November 17, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants