Phase2-hgx140 Change the ieta field to radius field for scintillator part

[bsunanda]

Maintain the ieta() method to keep up backward compatibility. But it is better to remove this in future after verifying the downstream codes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24331/6074

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29905/console Started: 2018/08/17 17:08

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/ForwardDetId

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 0664b02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24331/29905/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24331/29905/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2983602
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2983411
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[kpedro88]

@bsunanda a point of clarification about the geometry, I can think of two cases:

1. all the scintillator portions of the HGCal v9 non-projective (whether in the "FH" or "BH" section)
2. just the "BH" section is non-projective (whether silicon or scintillator)

Can you clarify which case is true?

[bsunanda]

I believe all scintillator positions are non-projective. They are at constant radius so that the tile size in each layer for a given eta/radius index are of identical size. The sizes are surely different in FH and BH part (FH is finer than BH)

[kpedro88]

Okay, then this change makes sense. Thanks!

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1