Run2-hcx181 Correct accessing constituents of CaloTower

[bsunanda]

Protect against Plan1 geometry as well as very forward tracks in Phase2 reconstruction

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24367/6131

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
RecoEgamma/EgammaIsolationAlgos
RecoLocalCalo/CaloTowersCreator

@perrotta, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

.. chances are this one will also fail in wf 4.22

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29982/console Started: 2018/08/22 22:13

[cmsbuild]

-1

Tested at: bfc7e12

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24367/29982/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[abdoulline]

As discussed elsewhere, this wf 4.22 fails everywhere.
But now the relevant data sample must have been copied on eos (manually), so the test may possibly run through.

[perrotta]

@cmsbuild please test

[slava77]

@cmsbuild please test

to pick up differences if any after the comparisons were updated in cms-sw/cms-bot#1020

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30077/console Started: 2018/08/27 19:22

[cmsbuild]

+1
Tested at: 61424d7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24367/30077/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24367/30077/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2992850
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2992657
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #24367 61424d7

• for reco this now re-enables a throw for unexpected detIds in calo tower components after fixing upstream
• jenkins tests pass and comparisons with the baseline show no differences (as expected).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1

[gpetruc]

I will include a rebase of this PR into the 10_2_X backport of #24212