Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making 2017 EGM IDs available for DQM modules #24379

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Sam-Harper
Copy link
Contributor

Dear All,

The top DQM was trying to use 2017 IDs in their DQM but the VID instance for DQM modules was not computing them. This issue was reported in #24376

This PR fixes it

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30020/console Started: 2018/08/23 17:45

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24379/30020/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 68 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2987459
  • DQMHistoTests: Total failures: 2869
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2984400
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5853d07 into cms-sw:master Aug 24, 2018
fabiocos added a commit to fabiocos/cmssw that referenced this pull request Sep 4, 2018
cmsbuild added a commit that referenced this pull request Sep 4, 2018
Backport of #24379 to 10_2_X, missing EGM ID modules for DQM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants