Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random generator service for FastSim - backport to 94X #24392

Merged
merged 7 commits into from Aug 28, 2018

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Aug 26, 2018

Backporting #21714 to 94X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2018

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/EventProducer
FastSimulation/ShowerDevelopment
FastSimulation/TrackingRecHitProducer
FastSimulation/Utilities

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 26, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30063/console Started: 2018/08/26 22:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24392/30063/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 35173
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2686158
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

backport of #21714

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 994fca2 into cms-sw:CMSSW_9_4_X Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants