Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang warnings in DetectorDescription/Core #24393

Merged
merged 2 commits into from Aug 28, 2018
Merged

Fix clang warnings in DetectorDescription/Core #24393

merged 2 commits into from Aug 28, 2018

Conversation

Dr15Jones
Copy link
Contributor

There were two classes of clang warnings

  • calling std::move on a temporary and
  • using fabs instead of std::abs

@Dr15Jones
Do not std::move a temporary
ed89d3b 
Calling std::move on a temporary keeps the compiler from being able
to do optimizations (copy ellision).
@Dr15Jones
Use std::abs instead of fabs
5ea9a97 
clang was warning that the use of fabs was truncating the values.
@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Aug 26, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24393/6171

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DetectorDescription/Core

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30064/console Started: 2018/08/26 22:20

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link
Contributor

ianna commented Aug 26, 2018

please hold
until #24355 is merged

@cmsbuild
Copy link
Contributor

+1
Tested at: 5ea9a97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393/30064/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393/30064/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2992850
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992658
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@Dr15Jones
Copy link
Contributor Author

@ianna Sorry if this stepped on your toes. I was hoping that by signing it myself I was making your life easier.

@ianna
Copy link
Contributor

ianna commented Aug 27, 2018

@Dr15Jones - no problem, it's just the other PR has been open for a couple of weeks and I hope it will be integrated ASAP - I need it for the DD IOV debugging.

@ianna
Copy link
Contributor

ianna commented Aug 28, 2018

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30099/console Started: 2018/08/28 17:01

@cmsbuild
Copy link
Contributor

+1
Tested at: 5ea9a97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393/30099/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393/30099/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143859
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143655
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

There are a few failures in 7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17 (Muons/TKTrack). Are these understood? (Probably not caused by this PR, but just want to check)

@kpedro88
Copy link
Contributor

Actually, it looks like these failures are showing up in other PR tests too, so never mind

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 175f91a into cms-sw:master Aug 28, 2018
@Dr15Jones Dr15Jones deleted the clangWarningsDetectorDescriptionCore branch August 31, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @ianna @kpedro88