substitute kHGCalEta with kHGCalRadius

[mrodozov]

Fix comp errors in IBs https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_10_3_X_2018-08-28-2300/L1Trigger/L1THGCal

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24405/6208

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30111/console Started: 2018/08/29 11:50

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

L1Trigger/L1THGCal

@nsmith-, @rekovic, @cmsbuild, @thomreis, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: a0ff3f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24405/30111/summary.html

[cmsbuild]

Comparison job queued.

[smuzaffar]

@bsunanda, @kpedro88 , this is need to fix the IBs build failures. Renaming of the variable was done here #24331

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24405/30111/summary.html

There are some workflows for which there are errors in the baseline:
20034.0 step 2
20434.0 step 2
21234.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2952815
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2952638
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 127 log files, 14 edm output root files, 29 DQM output files

[kpedro88]

+1

[kpedro88]

merge

[kpedro88]

@mrodozov @smuzaffar can we launch an intermediate IB now that this is merged, so other PR tests don't have to wait until 23:00?

[smuzaffar]

@kpedro88 , @mrodozov has started the IB now.