Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD Unlock Stores #24441

Merged
merged 1 commit into from Sep 3, 2018
Merged

DD Unlock Stores #24441

merged 1 commit into from Sep 3, 2018

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 3, 2018

  • Unlock the Stores for now. There are some issues with workflows running in multiple threads:

#24378 (comment)

@ianna
Copy link
Contributor Author

ianna commented Sep 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The code-checks are being triggered in jenkins.

@ianna ianna mentioned this pull request Sep 3, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30215/console Started: 2018/09/03 12:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Jenkins tests are aborted.

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

please test workflow 11626.0,12024.0,24034.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30219/console Started: 2018/09/03 14:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

-1

Tested at: 7d25ab8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24441/30219/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
24034.0 step2

runTheMatrix-results/24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

the failure looks independent on this PR and should be fixed by #24418 , try again

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

please test workflow 11626.0,12024.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30230/console Started: 2018/09/03 18:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24441/30230/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24441/11626.0_QCD_Pt_600_800_13+QCD_Pt_600_800_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24441/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019Design_GenSimFull+DigiFull_2019Design+RecoFull_2019Design+HARVESTFull_2019Design

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143879
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143681
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2018

merge

@ianna the fix has been proposed by you and it passes the tests, I assume you are ok with it and test it during the next IB, please sign it in case anyway

@cmsbuild cmsbuild merged commit 09aee0c into cms-sw:master Sep 3, 2018
@ianna
Copy link
Contributor Author

ianna commented Sep 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants