add check validity of edm::Handle in HLTDQM modules

[mtosi]

as pointed out in #24155 (comment)
and spotted / seen also in https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1978/1/1.html

some modules make the job crashing (!!!)
I've added the check of the handle validity

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_10_2_X.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @calderona, @HuguesBrun, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30222/console Started: 2018/09/03 15:40

[fabiocos]

@mtosi as we have discussed directly:

1. the fix prevents the crash, verified with Configuration/dataProcessing

python RunExpressProcessing.py --scenario ppEra_Run2_2018 --fevt --dqmio --global-tag 102X_dataRun2_Express_v2 --lfn /store/t0streamer/Data/Express/000/321/879/run321879_ls0315_streamExpress_StorageManager.dat

using as a source

process.source = cms.Source("NewEventStreamFileReader",
fileNames = cms.untracked.vstring('/store/t0streamer/Data/Express/000/321/879/run321879_ls0315_streamExpress_StorageManager.dat')
)

2. I suggest to add LogWarnings for a limited number of checks so as to avoid a silent failures but also to avoid filling log files with failure messages;

3. please forward-port to master;

4. again this is a work-around, not the ultimate solution (a proper management of the DQM express sequences discussed since long time).

[cmsbuild]

+1
Tested at: 3410be5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24445/30222/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #24445 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[mtosi]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30228/console Started: 2018/09/03 18:09

[schneiml]

@fabiocos as you mentioned, this does not really fix the problem, but a proper fix will be much harder/riskier.

IIRC @mtosi said that they don't need any HLT DQM in StreamExpress anyways, so we could just disable that entirely. Except we can't currently, since StreamExpress is using the default relval sequence...

Another thing that would be interesting is if we can reproduce this crash using runTheMatrix. Fixing WF 1001.2 to use the "proper", default sequence as used in real Express did not do it, but it is based on 2017 data. I wonder what else changed that causes this problem to appear in T0 express.

[cmsbuild]

+1
Tested at: 552f4a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24445/30228/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #24445 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[cmsbuild]

Pull request #24445 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[mtosi]

I've implemented the logic discussed with Fabio:

• check the InputTag is not empty
• only if it is not, then skip the event (not fill the plot)

and then I rebase for limiting / squeezing the number of commits

[mtosi]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30282/console Started: 2018/09/06 11:52

[mtosi]

@fabiocos could this PR be integrated and a patch release w/ this be built ?
TSG asked to PdmV to produce samples for the 102X validation w/ data, and we need this PR in

please, let me know if there is anything to do
and thanks !

[cmsbuild]

+1
Tested at: fede58c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24445/30282/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24445/30282/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2985378
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2985187
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 6.536 KiB( 30 files compared)
• DQMHistoSizes: changed ( 150.0,... ): 3.268 KiB HLT/B2G
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

@jfernan2 @schneiml @andrius-k could you please check and sign it in case?

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1