New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend Modifier boolean expressions to include "not" and "or" [94X] #24480
Conversation
…ressions of Modifiers For these to work I had to bypass the isChosen() checks of the contained Modifiers as they may not be enabled.
…r _{And,Invert,Or}Modifier
Using the same bypass of contained-Modifier isChosen() status as with toModify()
It's a bit simpler to avoid traversing the tree of Modifiers back to some leaf.
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_4_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: ed090f1 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testPythonParameterSet had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: ed090f1 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testPythonParameterSet had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@fabiocos please merge, the unit test failure is the usual one due to wrong file path, unrelated to this PR |
+1 |
merge |
This is a partial backport of #22210. Only the changes in
FWCore/ParameterSet/python/Config.py
were backported. The additionalModifier
functionality is needed in 94X for the ongoing fastsim backport.attn: @makortel @ssekmen