Fireworks: Fix in EveService (forward port to master) #24535

alja · 2018-09-13T17:10:35Z

Forward port of #24534

alja · 2018-09-13T17:10:42Z

+1

cmsbuild · 2018-09-13T17:10:52Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-13T17:13:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24535/6410

cmsbuild · 2018-09-13T17:13:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30401/console Started: 2018/09/13 19:14

cmsbuild · 2018-09-13T17:13:47Z

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Eve

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-09-13T19:26:42Z

+1
Tested at: b8bba0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24535/30401/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c5cccd5
caab4a4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24535/30401/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24535/30401/git-merge-result

cmsbuild · 2018-09-13T19:26:45Z

Comparison job queued.

cmsbuild · 2018-09-13T20:50:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24535/30401/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3147366
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3147168
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-09-14T07:44:38Z

Fireworks/Eve/plugins/DummyEvelyser.cc

         // The display() function runs the GUI event-loop and shows
         // whatever has been registered so far to eve.
         // It returns when user presses the "Step" button (or "Continue" or
         // "Next Event").
-         m_eve->display(std::string("DummyEvelyser::analyze done for:\n") + trk->GetName());
+         //m_eve->display(std::string("DummyEvelyser::analyze done for:\n") + trk->GetName());


@alja for my understanding, what is the implication of this comment? From the comment in the code I would say that a functionality is suppressed, and the loop is just use to update m_tracklist

cmsbuild · 2018-09-14T19:09:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-14T19:11:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24535/6429

alja · 2018-09-14T19:13:01Z

@fabiocos
I have displayed the status on the exit of analyse() function. The EveService::display() call exits DummyEvelyser, so it should not be in the construction of the graphic scene.

cmsbuild · 2018-09-14T19:13:38Z

Pull request #24535 was updated. @cmsbuild, @alja, @Dr15Jones can you please check and sign again.

alja · 2018-09-14T19:14:14Z

@rovere , here are brief instructions
https://twiki.cern.ch/twiki/bin/view/CMS/PhysicsToolsDevFireworksFFWEveService

alja · 2018-09-14T19:14:22Z

+1

cmsbuild · 2018-09-14T19:14:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30423/console Started: 2018/09/14 21:15

cmsbuild · 2018-09-14T19:14:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-09-14T19:43:59Z

+1
Tested at: 3ad4de2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24535/30423/summary.html

cmsbuild · 2018-09-14T19:44:02Z

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

fabiocos · 2018-09-17T07:49:10Z

+1

Replace getByLabel with getByToken

b8bba0a

cmsbuild added this to the CMSSW_10_3_X milestone Sep 13, 2018

cmsbuild added code-checks-pending comparison-pending fully-signed orp-pending tests-pending visualization-approved labels Sep 13, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 13, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 13, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 13, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 13, 2018

fabiocos reviewed Sep 14, 2018

View reviewed changes

alja added 2 commits September 14, 2018 12:08

Add option for input data file

9284d2c

Print info in the status bar on exit of DummyEvelyser::analyze()

3ad4de2

cmsbuild removed code-checks-approved comparison-available fully-signed labels Sep 14, 2018

cmsbuild added pending-signatures tests-pending visualization-pending labels Sep 14, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2018

cmsbuild added fully-signed visualization-approved and removed pending-signatures visualization-pending labels Sep 14, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 14, 2018

cmsbuild added comparison-notrun tests-approved and removed comparison-pending tests-started labels Sep 14, 2018

cmsbuild added orp-approved and removed orp-pending labels Sep 17, 2018

cmsbuild merged commit 5e49fe5 into cms-sw:master Sep 17, 2018

fabiocos mentioned this pull request Sep 25, 2018

Fireworks 10_2_X : Fix access of collections in EveService #24534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fireworks: Fix in EveService (forward port to master) #24535

Fireworks: Fix in EveService (forward port to master) #24535

alja commented Sep 13, 2018

alja commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018 •

edited

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

fabiocos Sep 14, 2018

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

alja commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

alja commented Sep 14, 2018

alja commented Sep 14, 2018

cmsbuild commented Sep 14, 2018 •

edited

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

fabiocos commented Sep 17, 2018

Fireworks: Fix in EveService (forward port to master) #24535

Fireworks: Fix in EveService (forward port to master) #24535

Conversation

alja commented Sep 13, 2018

alja commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018 • edited

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

cmsbuild commented Sep 13, 2018

fabiocos Sep 14, 2018

Choose a reason for hiding this comment

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

alja commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

alja commented Sep 14, 2018

alja commented Sep 14, 2018

cmsbuild commented Sep 14, 2018 • edited

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

fabiocos commented Sep 17, 2018

cmsbuild commented Sep 13, 2018 •

edited

cmsbuild commented Sep 14, 2018 •

edited