clean up SiPixel digitizer and clusterizer code removing variables used for pre-phase2 TDR studies

[emiglior]

This PR is some extra clean-up of PR #24325 and #24329.
In this PR we remove few parameters of the pixel digitizer and of the clusterizer (featuring "Stack" in the name of the variable) which were introduced long time ago in the code of the current pixel detector (phase1 pixel TDR epoch?) for preliminary studies on phase2 tracker and not are used anymore.

Additional details can be found in
https://hypernews.cern.ch/HyperNews/CMS/get/pixelOfflineSW/1433.html

People following these developments are : @avartak @suchandradutta @kpedro88
@mmusich @tsusa

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24546/6423

[cmsbuild]

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

HLTrigger/Configuration
RecoLocalTracker/SiPixelClusterizer
SimGeneral/MixingModule
SimTracker/SiPixelDigitizer

@perrotta, @cmsbuild, @civanch, @fwyzard, @mdhildreth, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@geoff-smith, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dkotlins, @gpetruc, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30420/console Started: 2018/09/14 16:56

[cmsbuild]

+1
Tested at: 5803f9c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24546/30420/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24546/30420/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3146592
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3146394
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[Martin-Grunewald]

+1

[perrotta]

+1

• In the current default and all used configs the removed feature is never used
  • In the digitiizer theAdcFullScaleStack==theAdcFullScale in the default and all used configs -> never used
  • In the clusterizer theStackADC == maxADC8bitVal_ == 255 -> never used
• From https://hypernews.cern.ch/HyperNews/CMS/get/pixelOfflineSW/1433/2.html :
  • In the digitiizer the “stack” stuff is only used for something called “P20TB” which must be a Phase2 component
  • In the clusterizer the first layer “stack” is used is layer 5, which cannot have anything to do with the present phase1 detector
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1