Migrate More to New Random Service Interface #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate SimWatchers and Hector related simulation code to use the new interface of the random number generator service designed to work with the multithreaded Framework. The SimWatchers are different than other simulation code because the call stack goes through GEANT functions and engines cannot be percolated. So SimWatchers use the global CLHEP engine (which is the same thing the current version of GEANT does). This CLHEP global will be a thread_local as soon as planned changes are made to CLHEP. The Hector code is different because it has TRandom3 hard coded in its interface, although it turns out that does not really affect the migration.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X. Migrate More to New Random Service Interface It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
ktf
added a commit
that referenced
this pull request
Feb 14, 2014
Multithreading fixes -- Migrate More Simulation to New Random Service Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate SimWatchers and Hector related simulation code
to use the new interface of the random number generator
service designed to work with the multithreaded Framework.
The SimWatchers are different than other simulation
code because the call stack goes through GEANT
functions and engines cannot be percolated. So
SimWatchers use the global CLHEP engine (which is
the same thing the current version of GEANT does).
This CLHEP global will be a thread_local as soon
as planned changes are made to CLHEP.
The Hector code is different because it has TRandom3
hard coded in its interface, although it turns out
that does not really affect the migration.