Added unit test to make sure poisoned datafiles are not read from release

[smuzaffar]

New git-cms-checkdeps ( cms-sw/cms-git-tools@612fa04 ) now poisons deleted datafile by creating a symlink to an emptry directory. This Allow us to make sure that a deleted datafile (from a src directory) is not read from CMSSW_RELEASE_BASE

This unit test simulates the git-cms-checkdeps behaviour and poisons Geometry/CMSCommonData/data/materials.xml

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24627/6531

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondTools/Geometry

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24627/6532

[cmsbuild]

Pull request #24627 was updated. @ggovi, @cmsbuild can you please check and sign again.

[smuzaffar]

please test
FYI @ianna

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30576/console Started: 2018/09/24 12:19

[cmsbuild]

+1
Tested at: 74baff3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24627/30576/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24627/30576/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3146876
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3146677
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

the unit tests looks succesfull