VBFGenJetFilter has been modfied in order to select generator level Mjj

[gmandorl]

VBFGenJetFilter.cc has been extended.
Possible requirements on the invariant mass of the two pt-leading genJets.
The considered genJets can also be asked to have a minimum DeltaR from the event charged prompt leptons.

[cmsbuild]

A new Pull Request was created by @gmandorl for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

• Backported from Updated vbf filter v2 #20394

[arizzi]

This is backport of a feature already integrated in master (and in older GEN-releases). It is needed to properly generate and filter VBF-Hmumu samples.

[kpedro88]

backport of #20394

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30626/console Started: 2018/09/25 16:17

[kpedro88]

@gmandorl at the moment is this is a not-quite-exact backport of the noted PR. Can you make it exact?

[cmsbuild]

Pull request #24651 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please check and sign again.

[kpedro88]

GeneratorInterface/GenFilters/BuildFile.xml was also updated in master

[gmandorl]

It seems to me there is no difference in BuildFile.xml

[kpedro88]

Ah, it looks like that change was already ported back to 9_3_X.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30633/console Started: 2018/09/25 18:05

[cmsbuild]

+1
Tested at: af8995c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24651/30633/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24651/30633/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2624448
• DQMHistoTests: Total failures: 225
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2624046
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
• Checked 105 log files, 8 edm output root files, 25 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@efeyazgan this PR is changing the default behaviour fo the release, am I correct? I think we should keep the values that do not modify the behaviour, and modify the parameters in the generator setup required for specific samples

[clacaputo]

Dear @efeyazgan, @qliphy, this PR is needed for ensuring the VBF filtering required in DYJetsToLL_M-105To160_VBFFilter requests that you can find here.

Could this feature be approved in an ORP meeting and a new release be made on 93X cycle for this?

Thanks.

[arizzi]

@fabiocos this should not change the default behaviour as leadJetsNoLepMass is default False

[fabiocos]

@arizzi ok, I see that the change of the false default in cfi is in a new PSet not previously present. So backward compatibility is conserved

[fabiocos]

+1