Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSimulation/ParticleDecay: replace auto_ptr removed in strict std=c++17 #24711

Merged
merged 1 commit into from Oct 11, 2018
Merged

FastSimulation/ParticleDecay: replace auto_ptr removed in strict std=c++17 #24711

merged 1 commit into from Oct 11, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 27, 2018

No description provided.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

FastSimulation/ParticleDecay

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen
Copy link
Contributor

ssekmen commented Sep 27, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30699/console Started: 2018/09/27 18:55

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24711/30699/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2416 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162160
  • DQMHistoTests: Total failures: 13137
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3148824
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.167 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): 0.167 KiB SiStrip/MechanicalView
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30949/console Started: 2018/10/09 18:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24711/30949/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162781
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@ssekmen any issue with this PR? otherwise could you please sign it?

@ssekmen
Copy link
Contributor

ssekmen commented Oct 11, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 05abfde into cms-sw:master Oct 11, 2018
@gartung gartung deleted the FastSimulation-ParticleDecay-strictcxx17 branch November 5, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants