Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My rivet 1.9.0 changes #2475

Merged
merged 6 commits into from Feb 26, 2014
Merged

Conversation

lsonnens
Copy link

Old temporary CMS analyses removed (have separate repository for these now).
One validated CMS example analysis added.
C-shell type script for Rivet paths added

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lsonnens (Lars Sonnenschein) for CMSSW_5_3_X.

My rivet 1.9.0 changes

It involves the following packages:

GeneratorInterface/RivetInterface

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vciulli
Copy link
Contributor

vciulli commented Feb 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

what is the purpose of the putting the aida file in cmssw? [other than being a very bad way to store a handful of numbers defining a histogram]

@lsonnens
Copy link
Author

This is an example analysis.
Therefore I have removed the hand full other analyses which have been
there before.

Lars

Dr. rer. nat. habil. Lars Sonnenschein


Home Institution:
RWTH Aachen
III. Phys. Inst. A, 26A204
Physikzentrum
52056 Aachen

Germany


CERN:
PH/UCM, 32/2C-07
CH-1211 Geneve 23
Switzerland

Tel.:+41(22)767-9875


FNAL:
D0, PK151
Mailstop #352
Fermilab, P.O.Box 500
Batavia, IL 60510-500
USA
Tel.: +1(630)840-8740


On Tue, 18 Feb 2014, davidlange6 wrote:

what is the purpose of the putting the aida file in cmssw? [other than being a very bad way to store a
handful of numbers defining a histogram]

?
Reply to this email directly or view it onGitHub.[5495246__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODI1MTM1OSwiZGF0YSI6eyJpZCI6MjU3MDM5
MTJ9fQ==--9b1339f11d4b6773a720529b52033f8b89d19012.gif]

@davidlange6
Copy link
Contributor

If the aida data is there for comparison within a test run - perhaps it could be digested via python script into a more code repository friendly format? (e.g., we don't store root files of this sort)

On Feb 18, 2014, at 11:22 AM, Lars Sonnenschein notifications@github.com
wrote:

This is an example analysis.
Therefore I have removed the hand full other analyses which have been
there before.

Lars


Dr. rer. nat. habil. Lars Sonnenschein


Home Institution:
RWTH Aachen
III. Phys. Inst. A, 26A204
Physikzentrum
52056 Aachen

Germany


CERN:
PH/UCM, 32/2C-07
CH-1211 Geneve 23
Switzerland

Tel.:+41(22)767-9875


FNAL:
D0, PK151
Mailstop #352
Fermilab, P.O.Box 500
Batavia, IL 60510-500
USA
Tel.: +1(630)840-8740


On Tue, 18 Feb 2014, davidlange6 wrote:

what is the purpose of the putting the aida file in cmssw? [other than being a very bad way to store a
handful of numbers defining a histogram]

?
Reply to this email directly or view it onGitHub.[5495246__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODI1MTM1OSwiZGF0YSI6eyJpZCI6MjU3MDM5
MTJ9fQ==--9b1339f11d4b6773a720529b52033f8b89d19012.gif]


Reply to this email directly or view it on GitHub.

@lsonnens
Copy link
Author

Yes this aida file is for comparison with MC generated events.
The format is already human readable. There are scripts to convert to ROOT
format and to flat text format. But the text format is not more human
readable. I would like to have this example file exactly in the format
that users would need to provide for their own published analyses so that
they find a complete example in its needed form without additional
hurdles and ambiguities.

Lars

Dr. rer. nat. habil. Lars Sonnenschein


Home Institution:
RWTH Aachen
III. Phys. Inst. A, 26A204
Physikzentrum
52056 Aachen

Germany


CERN:
PH/UCM, 32/2C-07
CH-1211 Geneve 23
Switzerland

Tel.:+41(22)767-9875


FNAL:
D0, PK151
Mailstop #352
Fermilab, P.O.Box 500
Batavia, IL 60510-500
USA
Tel.: +1(630)840-8740


On Tue, 18 Feb 2014, davidlange6 wrote:

If the aida data is there for comparison within a test run - perhaps it could be digested via python
script into a more code repository friendly format? (e.g., we don't store root files of this sort)

On Feb 18, 2014, at 11:22 AM, Lars Sonnenschein notifications@github.com
wrote:

This is an example analysis.
Therefore I have removed the hand full other analyses which have been
there before.

Lars


Dr. rer. nat. habil. Lars Sonnenschein


Home Institution:
RWTH Aachen
III. Phys. Inst. A, 26A204
Physikzentrum
52056 Aachen

Germany


CERN:
PH/UCM, 32/2C-07
CH-1211 Geneve 23
Switzerland

Tel.:+41(22)767-9875


FNAL:
D0, PK151
Mailstop #352
Fermilab, P.O.Box 500
Batavia, IL 60510-500
USA
Tel.: +1(630)840-8740


On Tue, 18 Feb 2014, davidlange6 wrote:

what is the purpose of the putting the aida file in cmssw? [other than being a very bad way to store a
handful of numbers defining a histogram]

?
Reply to this email directly or view itonGitHub.[5495246__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODI1MTM1OSwiZGF0YSI6eyJpZCI6MjU3MD
M5
MTJ9fQ==--9b1339f11d4b6773a720529b52033f8b89d19012.gif]

?
Reply to this email directly or view it on GitHub.

?
Reply to this email directly or view it onGitHub.[5495246__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODI1MTkzNywiZGF0YSI6eyJpZCI6MjU3MDM5
MTJ9fQ==--028bb5b5a18b8bee0646ff4128a3747063055b88.gif]

@davidlange6
Copy link
Contributor

+1

smuzaffar added a commit that referenced this pull request Feb 26, 2014
@smuzaffar smuzaffar merged commit 1f0a46c into cms-sw:CMSSW_5_3_X Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants