Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move numberOfDaughters() and daughter(size_t) outside class declaration #2477

Merged
merged 1 commit into from Feb 15, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 14, 2014

Break virtual inline. This will make numberOfDaughters() and
daughter(size_t) symbols with GLOBAL binding. Before it was in LOCAL
binding thus breaking compilation of testCommonToolsUtil from
CommonTools/Utils. Needed for GCC 4.9.0.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Break virtual inline. This will make numberOfDaughters() and
daughter(size_t) symbols with GLOBAL binding. Before it was in LOCAL
binding thus breaking compilation of `testCommonToolsUtil' from
CommonTools/Utils. Needed for GCC 4.9.0.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_1_X.

Move numberOfDaughters() and daughter(size_t) outside class declaration

It involves the following packages:

DataFormats/PatCandidates

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Feb 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2477/186/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@davidlt
Copy link
Contributor Author

davidlt commented Feb 15, 2014

Merging. RelVals are fine, DAS didn't provide a list of input files.

davidlt added a commit that referenced this pull request Feb 15, 2014
Move numberOfDaughters() and daughter(size_t) outside class declaration
@davidlt davidlt merged commit 4a0ef19 into cms-sw:CMSSW_7_1_X Feb 15, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants