Phase2-hgx157 Update the standalone digi study of HGCal (upgrade) to give reasonable o/p

[bsunanda]

Also split it up for each sub detector

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24796/6739

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Validation/HGCalValidation

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30876/console Started: 2018/10/03 18:29

[cmsbuild]

+1
Tested at: bc55664
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24796/30876/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24796/30876/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162909
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162710
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

Hi @bsunanda, could you please make sure that the there is a name of a subsystem in the title of the PR?

[rovere]

@bsunanda ,
while I have nothing in abstract terms against test code that could be run standalone, I do feel the need to discuss this kind of tools in a more general way with a bigger audience, so that relevant people are aware of their existence.

Also, I'm strongly in favour of adding as much DQM/Validation as needed/possible for the HGCal detector, having an accompanying Twiki page that explains what it does (and also how would be a wonderful plus).

[bsunanda]

@rovere I fully agree with this. This is done on request by Kaushik who is doing some validation work and I shall ask him to prepare the twiki page with all validation tools and also discuss about all validation tool within DPG

[bsunanda]

@andrius-k Sorry I missed out the name which I have now added

[bsunanda]

@andrius-k Could you sign this please?

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1