Kalman BMTF Emu v2.7

[panoskatsoulis]

This is the latest BMTF emulator for the Kalman algorithm

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24855/6819

[cmsbuild]

A new Pull Request was created by @panoskatsoulis for master.

It involves the following packages:

DataFormats/L1TMuon
L1Trigger/L1TMuonBarrel

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31016/console Started: 2018/10/13 11:43

[cmsbuild]

-1

Tested at: 13f5b18

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24855/31016/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[thomreis]

Hi @panoskatsoulis
since the master points to the 10_4 branch now please also make a backport PR to 10_3_X after fixing the compilation warnings.

[thomreis]

Hi @panoskatsoulis
please fix the compilation warnings in order to go ahead with this PR's integration.

[panoskatsoulis]

hi @thomreis
the procedure fails because of 2 Clang warnings (namely -Wself-assign-overloaded & -Wheader-guard).
The last commit I've pushed fixes them in my local tests.

In details, -Wheader-guard is just a typo in the first line of the file
'L1Trigger/L1TMuonBarrel/interface/L1TMuonBarrelKalmanLUTs.h',
but -Wself-assign-overloaded raised during compilation because of the line 226 in the file
'L1Trigger/L1TMuonBarrel/src/L1TMuonBarrelKalmanRegionModule.cc'.
line 226: s3_3=s3_3;
The assignment of an object to itself now raises this warning.
In the release notes of the Clang (link) is proposed to cast the rhs as reference of the object, in order to suppress the warning.
line 226: s3_3=static_cast<L1MuKBMTrack&>(s3_3);

Can we please test again and see if this fixes the issue?
Also, @bachtis confirm please that this fix will not affect the algorithm.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[panoskatsoulis]

Hi @thomreis, I've checked again. In deed the failures exist due to the old runs used by the workflow, and also we need to keep in mind that this PR changes the emulator. With that in mind, differences are being expected even for runs in which the emulator run.

[thomreis]

Hi @panoskatsoulis thanks for the additional confirmation.
@fabiocos this is finally ready to be merged.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32372/console Started: 2018/12/27 15:05

[cmsbuild]

+1
Tested at: 75642cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24855/32372/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
75642cf
a11ff06
772f26f
493867b
677b794
ed3bfda
5785990
5b61323
39496c0
dd5d918
5b3b317
2d4e11a
14d4e71
500def7
f7cf8dc
380f1a4
27bbf6e
60a254c
b715917
f246f43
8b204e4
8faf979
6c74072
7a65e90
6132127
a27ec47
1f78113
9173af8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24855/32372/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24855/32372/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24855/32372/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 74
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153439
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@thomreis @panoskatsoulis the PR looks ready for integration, just one clarification: I see several pieces of code that are not just debugging printouts commented: what is the purpose of that? In principle this might turn into a time bomb if not properly documented.

[panoskatsoulis]

Hello, @fabiocos this question is for @bachtis .

[bachtis]

Hi Fabio, We will clean it up some time in the future - but I suggest we merge this now. We will have additional developments and PRs in the near future so we can clean it up .

[fabiocos]

+1