PFEGammaProducer with fillDescriptions #24863

guitargeek · 2018-10-14T17:52:53Z

Continuing cleaning up the PFEGammaProducer/Algo.

This time, I moved the configuration to the fillDescriptions function and removed unused parameters on that occasion.

Local matrix tests pass.

cmsbuild · 2018-10-14T17:53:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-14T17:54:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24863/6833

cmsbuild · 2018-10-14T17:55:15Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-10-14T19:29:32Z

@cmsbuild please test

cmsbuild · 2018-10-14T19:29:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31024/console Started: 2018/10/14 22:31

cmsbuild · 2018-10-14T22:29:49Z

+1
Tested at: 362e8a5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24863/31024/summary.html

cmsbuild · 2018-10-14T22:29:52Z

Comparison job queued.

cmsbuild · 2018-10-15T00:10:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24863/31024/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994723
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994524
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

perrotta

Please also consider adding comments to (some of) the parameters inserted with your fillDescription method (see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideConfigurationValidationAndHelp#Adding_Comments) so that the auto-produced cfi will become more easily readable

perrotta · 2018-10-18T08:34:44Z

RecoParticleFlow/PFProducer/interface/PFEGammaAlgo.h

@@ -127,7 +127,6 @@ class PFEGammaAlgo {
    std::string mvaweightfile ;
    double mvaConvCut;
    bool useReg;


This useReg can also get removed from the class members

perrotta · 2018-10-18T08:54:20Z

RecoParticleFlow/PFProducer/plugins/PFEGammaProducer.cc

+    psd0.add<bool>  ("bCorrect",            true);
+    psd0.add<double>("dptRel_MergedTrack",  5.0);
+    psd0.add<double>("dptRel_PrimaryTrack", 10.0);
+    desc.add<edm::ParameterSetDescription>("iCfgCandConnector", psd0);


Is this pset really needed, or could it be also cleaned?

perrotta · 2018-10-18T08:56:16Z

RecoParticleFlow/PFProducer/plugins/PFEGammaProducer.cc

+  desc.add<bool>           ("pf_electronID_crackCorrection",    false);
+  desc.add<double>         ("pf_conv_mvaCut",                   0.0);
+  desc.add<double>         ("sumPtTrackIsoForPhoton",           2.0);
+  desc.add<double>         ("sumPtTrackIsoSlopeForPhoton",      0.001);


Is this needed?

perrotta · 2018-10-18T09:00:32Z

RecoParticleFlow/PFProducer/plugins/PFEGammaProducer.cc

+  desc.add<double>         ("pf_electron_mvaCut",               -0.1);
+  desc.add<bool>           ("pf_electronID_crackCorrection",    false);
+  desc.add<double>         ("pf_conv_mvaCut",                   0.0);
+  desc.add<double>         ("sumPtTrackIsoForPhoton",           2.0);


This is for the PFPhotonAlgo: since you are cleaning, is it really needed here?

cmsbuild · 2018-10-18T13:38:56Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-18T13:41:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24863/6899

cmsbuild · 2018-10-18T13:41:57Z

Pull request #24863 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2018-10-18T13:44:55Z

please test

cmsbuild · 2018-10-18T13:45:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31136/console Started: 2018/10/18 15:45

cmsbuild · 2018-10-18T15:57:50Z

+1
Tested at: cc23f45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24863/31136/summary.html

cmsbuild · 2018-10-18T15:57:53Z

Comparison job queued.

cmsbuild · 2018-10-18T17:40:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24863/31136/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994645
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

perrotta · 2018-10-22T17:44:49Z

+1

PFEGammaProducer cleaned from unused class members and configuration parameters; fillDescription() method is added to deal with those parameters
Said so, the pull request is kind of technical: no effects are visible in the standard outputs, and none were expected

cmsbuild · 2018-10-22T19:54:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-23T07:47:37Z

+1

guitargeek added 3 commits October 14, 2018 13:13

Moved PFEGammaProducer config to fillDescriptions

9fba76a

Removed unused regression parameters

d3d0af4

Further reductions

362e8a5

cmsbuild added this to the CMSSW_10_4_X milestone Oct 14, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 14, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 14, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 15, 2018

perrotta reviewed Oct 18, 2018

View reviewed changes

cmsbuild removed code-checks-approved comparison-available tests-approved labels Oct 18, 2018

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 18, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 18, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 22, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 23, 2018

cmsbuild merged commit 1919f96 into cms-sw:master Oct 23, 2018

guitargeek deleted the PFEGammaProducer_fillDescriptions branch December 9, 2018 20:37

slava77 mentioned this pull request May 29, 2020

Excessive (or not?) files open in cmsRun jobs #18688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PFEGammaProducer with fillDescriptions #24863

PFEGammaProducer with fillDescriptions #24863

guitargeek commented Oct 14, 2018 •

edited

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

slava77 commented Oct 14, 2018

cmsbuild commented Oct 14, 2018 •

edited

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 15, 2018

perrotta left a comment

perrotta Oct 18, 2018

perrotta Oct 18, 2018

perrotta Oct 18, 2018

perrotta Oct 18, 2018

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

perrotta commented Oct 18, 2018

cmsbuild commented Oct 18, 2018 •

edited

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

perrotta commented Oct 22, 2018

cmsbuild commented Oct 22, 2018

fabiocos commented Oct 23, 2018

PFEGammaProducer with fillDescriptions #24863

PFEGammaProducer with fillDescriptions #24863

Conversation

guitargeek commented Oct 14, 2018 • edited

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

slava77 commented Oct 14, 2018

cmsbuild commented Oct 14, 2018 • edited

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 14, 2018

cmsbuild commented Oct 15, 2018

perrotta left a comment

Choose a reason for hiding this comment

perrotta Oct 18, 2018

Choose a reason for hiding this comment

perrotta Oct 18, 2018

Choose a reason for hiding this comment

perrotta Oct 18, 2018

Choose a reason for hiding this comment

perrotta Oct 18, 2018

Choose a reason for hiding this comment

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

perrotta commented Oct 18, 2018

cmsbuild commented Oct 18, 2018 • edited

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

cmsbuild commented Oct 18, 2018

perrotta commented Oct 22, 2018

cmsbuild commented Oct 22, 2018

fabiocos commented Oct 23, 2018

guitargeek commented Oct 14, 2018 •

edited

cmsbuild commented Oct 14, 2018 •

edited

cmsbuild commented Oct 18, 2018 •

edited