[10_3_X] Fixed copy-paste typo in Spring15 photon MVA weight file names

[guitargeek]

Hi,

unfortunately I introduced a typo with #24131 in the Spring15 Photon MVA. This ID is not supported anymore and we only noticed it during the preparation of the Fall17 V2 ID backport to 9_4_X. It is not enabled by default, that's why we didn't catch this in #24131.

Even thought it's a deprecated ID, I think it's not appropriate to let it break in the 10_3_0 release in this ungraceful way, so I hope I'm still in time...

My personal validation workflow shows now agreement of the Spring15 photon MVAs between this PR and 9_4_9.

Jonas

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for CMSSW_10_3_X.

It involves the following packages:

RecoEgamma/PhotonIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from [10_4_X] Fixed copy-paste typo in Spring15 photon MVA weight file names #24937

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31078/console Started: 2018/10/16 16:58

[cmsbuild]

+1
Tested at: 06ada0c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31078/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8b7d524
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31078/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31078/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31078/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 13
• DQMHistoTests: Total successes: 3162752
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 72.149 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10042.0,... ): 3.671 KiB L1TEMU/L1TStage2CaloLayer2
• DQMHistoSizes: changed ( 10042.0,... ): 1.140 KiB L1T/L1TStage2CaloLayer2
• DQMHistoSizes: changed ( 136.731,... ): 3.663 KiB L1TEMU/L1TStage2CaloLayer2
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

@cmsbuild please test

to get cleaner test results
(as well as also having working fwlite-based reco comparisons)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31148/console Started: 2018/10/18 21:47

[cmsbuild]

+1
Tested at: 06ada0c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31148/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24890/31148/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3163099
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162901
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

BTW, is there a master version of this code update?

[guitargeek]

Not yet, my hope was that this gets in the 10_3_0 release and therefore merged to the 10_4_X dev cycle. Since that did not happen, you think I should do another PR with this bugfix commit rebased onto master?

[perrotta]

Yes, that's the rule... Jonas Rembser <notifications@github.com> ha scritto:

…

Not yet, my hope was that this gets in the 10_3_0 release and therefore merged to the 10_4_X dev cycle. Since that did not happen, you think I should do another PR with this bugfix commit rebased onto master? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #24890 (comment)

[guitargeek]

Ok, I did that: #24937.

[perrotta]

backport of #24937

[perrotta]

type bugfix

[perrotta]

+1

• Fixed the name of the mva weight file for EE
• Jenkins tests pass, with no visible differences because the Spring15 Photon MVA ID is not supported any more

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1