Centrality reco modification for 2018 heavy ion run

[YeonjuGo]

fixed pixel collection name to be able to read them
and added hfecut, pixelplus, pixelminus, pixeltrackplus, pixeltrackminus variables
: https://twiki.cern.ch/twiki/pub/CMS/HiCentrality2018/181017_RecoModification_hf_pixel_variables_GO.pdf

updated pixel cut
: https://twiki.cern.ch/twiki/pub/CMS/HiCentrality2018/pixel-cluster-size-181018.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24892/6858

[cmsbuild]

A new Pull Request was created by @YeonjuGo for master.

It involves the following packages:

DataFormats/HeavyIonEvent
RecoHI/HiCentralityAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @yenjie, @rovere, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31082/console Started: 2018/10/16 19:00

[slava77]

@YeonjuGo
please provide some plots (or a link to a presentation in a HI group meeting) to describe the updates and expected differences in the baseline and with the proposed changes.
Thank you.

[cmsbuild]

-1

Tested at: 7cb46bc

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24892/31082/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24892/31082/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24892/6915

[cmsbuild]

Pull request #24892 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[YeonjuGo]

@slava77
I fixed things as you commented and also updated one more part.
The new update is about pixel cut. We've been using this cut which is tuned for pre-phase 1 pixel detectors. So we'd like to update it. You can refer to the study on this: https://twiki.cern.ch/twiki/pub/CMS/HiCentrality2018/pixel-cluster-size-181018.pdf
Thank you.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31183/console Started: 2018/10/19 23:14

[cmsbuild]

+1
Tested at: 16baa76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24892/31183/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24892/31183/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994644
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24892 16baa76

• centrality reco is updated in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show differences only in the HI workflows in the centrality monitoring plots
  e.g. in 140.53

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1