New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pat::Muon member function declaration bug fix #24901

Merged

cmsbuild merged 1 commit into cms-sw:master from bmahakud:MuonFunctionBugFix

Oct 23, 2018

Contributor

bmahakud commented Oct 17, 2018

Just a bug fix to declare the triggered function as const.
This would ensure the object is not altered when the method is called.
Before:
bool triggered( const char * pathName ) {
return triggerObjectMatchByPath(pathName,true,true)!=nullptr;
}
after:
bool triggered( const char * pathName ) const {
return triggerObjectMatchByPath(pathName,true,true)!=nullptr;
}


          muon function bugfix

0334c9d

cmsbuild added this to the CMSSW_10_4_X milestone

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels

Contributor

cmsbuild commented Oct 17, 2018

The code-checks are being triggered in jenkins.

Contributor

cmsbuild commented Oct 17, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24901/6870

cmsbuild added code-checks-approved and removed code-checks-pending labels

Contributor

cmsbuild commented Oct 17, 2018

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @drkovalskyi, @rovere, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Contributor

perrotta commented Oct 17, 2018

please test

Contributor

cmsbuild commented Oct 17, 2018 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31098/console Started: 2018/10/17 10:36

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Oct 17, 2018

-1

Tested at: 0334c9d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24901/31098/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

Contributor

cmsbuild commented Oct 17, 2018

Comparison job queued.

cmsbuild added tests-rejected and removed tests-started labels

bmahakud closed this

Contributor

cmsbuild commented Oct 17, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24901/31098/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994644
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

Contributor

fabiocos commented Oct 21, 2018

@bmahakud sorry why was this PR closed? The reported error was independent on your PR...

Contributor Author

bmahakud commented Oct 21, 2018 •

edited

@fabiocos Thanks for letting me know. Had not looked into it in detail. Thought to relaunch after fixing. Can you clarify further what is the error related about and how could it be fixed before re opening the PR?

Contributor

fabiocos commented Oct 21, 2018

@bmahakud it was a problem induced by a root patch, seen in IB and in the test of several other PRs

bmahakud reopened this

Contributor Author

bmahakud commented Oct 21, 2018

@fabiocos Thanks for clarification. Sorry for limited knowledge regarding PR. But how could it fixed ? What would be action item for me? changing to some other version of CMSSW? Or is it okay to proceed with this as the error is known?

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test
(to refresh the tests, since the root issue in the IB is fixed now)

4 similar comments

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test
(to refresh the tests, since the root issue in the IB is fixed now)

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test
(to refresh the tests, since the root issue in the IB is fixed now)

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test
(to refresh the tests, since the root issue in the IB is fixed now)

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test
(to refresh the tests, since the root issue in the IB is fixed now)

Contributor

perrotta commented Oct 22, 2018

@cmsbuild please test

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels

Contributor

cmsbuild commented Oct 22, 2018 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31207/console Started: 2018/10/22 23:20

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Oct 23, 2018

+1
Tested at: 0334c9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24901/31207/summary.html

Contributor

cmsbuild commented Oct 23, 2018

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Oct 23, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24901/31207/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994644
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

Contributor

perrotta commented Oct 23, 2018

+1

Technical
Jenkins tests pass

cmsbuild added reconstruction-approved and removed reconstruction-pending labels

bmahakud mentioned this pull request

DQM TriggerMatch Monitor to Watch the Trigger matching feature in pat::Muon #24936

Closed

Contributor

fabiocos commented Oct 23, 2018

+1

Contributor

fabiocos commented Oct 23, 2018

merge

cmsbuild added orp-approved and removed orp-pending labels

cmsbuild merged commit 3d9ebb2 into cms-sw:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment