Implemented option to run jobs in parallel for PV validation #24906
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24906/6875 |
|
A new Pull Request was created by @cardinia for master. It involves the following packages: Alignment/OfflineValidation @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| if self.NJobs > 1: | ||
| raise AllInOneError("Parallel jobs not implemented for the PrimaryVertex validation!\n" | ||
| "Please set parallelJobs = 1.") | ||
| # if self.NJobs > 1: |
There was a problem hiding this comment.
@cardinia why keep the commented out lines?
There was a problem hiding this comment.
@mmusich , they can be removed without problems. I initially thought that keeping them could be useful when working on the Parallel Validation code itself to loosen some of the current limitations (number of jobs to be sent in parallel or the need to specify the maximum number of events). But that was just a thought, their usefulness is basically none, I can remove those lines without problems.
|
Comparison job queued. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-approved
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24906/6881 |
|
Comparison is ready Comparison Summary:
|
|
@smuzaffar not sure why the status of test and comparison was not updated |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
@fabiocos , PR was updated that is why test and comparison signatures were sent to pending. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
@connorpa
Option for running jobs in parallel for the Primary Vertex Validation implemented and tested as discussed in Tracker Alignment meeting (https://indico.cern.ch/event/750047/#35-parallelisation-of-validati)