Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw data mapper sequence backport #24921

Merged
merged 9 commits into from Oct 18, 2018

Conversation

icali
Copy link
Contributor

@icali icali commented Oct 18, 2018

hi, it is a backport of #24910. No changes in the code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

A new Pull Request was created by @icali (Ivan Amos Cali) for CMSSW_10_3_X.

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
EventFilter/RawDataCollector

@cmsbuild, @prebello, @zhenhu, @emeschi, @kpedro88, @pgunnell, @franzoni, @mommsen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Oct 18, 2018

@cmsbuild please test workflow 140.55

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31131/console Started: 2018/10/18 12:30

@slava77
Copy link
Contributor

slava77 commented Oct 18, 2018

backport of #24910

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1

tests approved

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24921/31131/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162900
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@boudoul
Copy link
Contributor

boudoul commented Oct 18, 2018

dear @prebello , as usual the review process is implying to look first at the master PR , and then check that the backport is consistent with the master , could you please sign there ?

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

@mommsen @kpedro88 at this point I think we should move forward with this backport and build 10_3_0

@fabiocos
Copy link
Contributor

+1

the backport corresponds to the original version of the code approved nd merged in master

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 11264ce into cms-sw:CMSSW_10_3_X Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants