MTD simulation: fix to the BTL digitization

[casarsa]

This is a small fix to the BTL digitization: there was an issue with the way the saturation of ADC and TDC counts was implemented, resulting in a loss of BTL hits.
The code was tested with100 events of workflows 22440.0 and 22434.0.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24991/6969

[cmsbuild]

A new Pull Request was created by @casarsa (Massimo Casarsa) for master.

It involves the following packages:

SimFastTiming/FastTimingCommon

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test workflow 22434.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31263/console Started: 2018/10/25 11:54

[cmsbuild]

+1
Tested at: b9aefa9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24991/31263/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24991/31263/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

results obtained using this fix have been presented in the MTD DPG https://indico.cern.ch/event/764434/contributions/3188652/attachments/1742669/2820132/Benaglia_DPGMeeting_2018_10_26.pdf

[fabiocos]

+1