L1T CaloL2 O2O Fixes for HI **10_3_X BACKPORT** #25010
Conversation
|
A new Pull Request was created by @bundocka for CMSSW_10_3_X. It involves the following packages: L1Trigger/L1TCalorimeter @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
bundocka
changed the title
|
This supersedes #24923. |
|
please test |
|
The tests are being triggered in jenkins. |
|
@bundocka is now making a PR to master 10_4_X. |
|
backport of #25012 |
|
-1 Tested at: 765c612 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation warning while trying to compile with clang. Command used: See details on the summary page. The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
cmsbuild
added
backport
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
from a detailed check of the differences, I see that this PR brings the corresponding files in sync with 10_4_X, apart for minor differences in L1Trigger/L1TCalorimeter/plugins/L1TCaloParamsESProducer.cc coming from the code cleaning for C++17 compatibility, done in 10_4_X |
|
+1 |
Fixes a number of bugs in the L1T CaloL2 O2O
Tested O2O code produces payload that matches HI static config caloParams v1_4