L1T CaloL2 O2O Fixes for HI

[bundocka]

Fixes a number of bugs in the L1T CaloL2 O2O
Tested O2O code produces payload that matches HI static config caloParams v1_4

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25012/6987

[cmsbuild]

A new Pull Request was created by @bundocka for master.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/Utilities

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31285/console Started: 2018/10/26 11:01

[cmsbuild]

-1

Tested at: d6d7c36

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25012/31285/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[rekovic]

Hi @bundocka
The failing job log is available here.

[rekovic]

@bundocka
You should be able to reproduce it is with the above command already reported

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31379/console Started: 2018/10/30 17:30

[Martin-Grunewald]

Hi,

The failing addOnTest is a FastSim test (fastsim1), unrelated to HLT, so not affected by it

Module: FastSimProducer:fastSimProducer (crashed)
Module: GsfTrackProducer:electronGsfTracks
Module: MuonAssociatorEDProducer:tpToTkMuonAssociation
Module: TrackMVAClassifierPrompt:initialStepClassifier1

It is configured as:

# with command line options: TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns

ie, note the specific GT which uses a L1T stage-1 setup (as opposed to legacy/Run-1 or stage-2 L1T)
This workflow does not run any HLT menu.

[rekovic]

why doesn't this fail for 10_3_X PR #25010 ?

[fabiocos]

@rekovic might be a transient failure? It would not be the first time, let's see whether it is reproducible

[cmsbuild]

+1
Tested at: a269440
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25012/31379/summary.html

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25012/31379/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 69
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994577
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

DQM differences are concentrated in the L1T sector