Fix GenHFHadronMatcher [master] #25026
Conversation
Avoid a segmentation fault in the case of a tau particle not having a mother particle. This was seen during nanoAOD processing.
Although the ParticleDataTable was pulled from the EventSetup, it was never used.
It was possible to change all member data of GenHFHadronMatcher to be const and the module was not calling any thread unsafe external functions. It was therefore easy to convert to a global module. In addition, it now used EDPutTokens and edm::Event::emplace which further improve the efficiency of the module.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25026/6997 |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: PhysicsTools/JetMCAlgos @cmsbuild, @fgolf, @peruzzim, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi @Dr15Jones , you may also want to backport it to 10_2_X ? |
I will leave that to others if there is a need. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
please test workflow 10887.0,11087.0 |
|
The tests are being triggered in jenkins. |
|
please test workflow 10887.0,11087.0 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
Hi @fabiocos , for some reason, 10887.0,11087.0 didn't run, and I could not find the logs for them. |
|
@zhenhu the wfs 10887.0,11087.0 are not part of the standard test library, they are in the upgrade section of runTheMatrix that can be accessed through the option --what upgrade. This is not accessible to my knowledge in the bot tests (@smuzaffar do you confirm ?) Running these tests in a normal test area I see them successful with the PR, please cross-check |
|
@ahinzmann @zdemirag please notice this fix, looking at the code I assume it is ok, but it is unclear to me how to test it. I see a test cfg that seem not functional because of input files not found, and anyway one should have a quick way of inspecting the tree content. Do you have this kind of tests? |
|
@mverzett @kskovpen @ferencek It would be good if you could have a look at this hadron definition? (since its main consumer is b-tagging obviously) |
|
@ahinzmann any news on this? |
|
@mverzett @kskovpen @ferencek @rappoccio @dnash86 @gkasieczka Can you please comment? |
|
The real changes are minimal look good to me and thanks for updating the code to a more modern style. |
|
+1 |
|
merge |
|
Apologies for the late response. I haven't noticed right away I was mentioned here. @ahinzmann this flavour code was introduced back in 2014 for some specific analyses in the Higgs PAG, if I remember correctly. It is actually not used by the BTV POG and I am not really sure who would claim the ownership of this code right now. In any case, thanks to @Dr15Jones for the fix and other code improvements. |
The nanoAOD jobs were crashing in GenHFHadronMatcher because of a missing simulation parentage of a tau. This was fixed with the first commit.
Took the opportunity to modernize the module, especially since it is being used in an 8 thread job.