Remove some const-away casts from analysis

[makortel]

To clean up static analyzer reports.

Tested in CMSSW_10_4_X_2018-10-25-2300, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25039/7015

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25039/7015/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25039/7015/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25039/7016

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

AnalysisAlgos/TrackInfoProducer
MuonAnalysis/MomentumScaleCalibration
TopQuarkAnalysis/TopEventProducers
TopQuarkAnalysis/TopHitFit

@cmsbuild, @fgolf, @peruzzim, @monttj can you please review it and eventually sign? Thanks.
@bellan, @mmusich, @kreczko, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

So we still have code that has not gone through the style checks?

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31338/console Started: 2018/10/29 17:37

[cmsbuild]

+1
Tested at: be9998a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25039/31338/summary.html

[cmsbuild]

Comparison job queued.

[makortel]

@cmsbuild, please abort

[cmsbuild]

Jenkins tests are aborted.

[cmsbuild]

The code-checks are being triggered in jenkins.

[makortel]

Added one case in PatJetHitFitTranslator.cc that I missed earlier. Also took the opportunity to remove catch(...) from MuScleFitMuonSelector.cc that the "CMSSW Code Rules" complained about.

[makortel]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25039/7024

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31345/console Started: 2018/10/29 20:23

[cmsbuild]

Pull request #25039 was updated. @cmsbuild, @fgolf, @peruzzim, @monttj can you please check and sign again.

[cmsbuild]

+1
Tested at: 3f7a205
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25039/31345/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25039/31345/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994644
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

[fabiocos]

merge