Remove some const-away casts from FastSim

[makortel]

To clean up static analyzer reports.

Tested in CMSSW_10_4_X_2018-10-25-2300, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25044/7020

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FastSimulation/CaloHitMakers
FastSimulation/ShowerDevelopment

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31342/console Started: 2018/10/29 18:12

[cmsbuild]

-1

Tested at: 773b884

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25044/31342/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[makortel]

Umm
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25044/31342/runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

Thread 1 (Thread 0x7fed92bd33e0 (LWP 9672)):
#0  0x00000036c7adf403 in poll () from /lib64/libc.so.6
#1  0x00007fed8d3efbc7 in full_read.constprop () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/pluginFWCoreServicesPlugins.so
#2  0x00007fed8d3f025c in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/pluginFWCoreServicesPlugins.so
#3  0x00007fed8d3f12c7 in sig_dostack_then_abort () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/pluginFWCoreServicesPlugins.so
#4  <signal handler called>
#5  0x00007fed20e9b000 in ?? ()
#6  0x00007fed85e322c9 in reco::parser::MethodInvoker::invoke(edm::ObjectWithDict const&, edm::ObjectWithDict&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libCommonToolsUtils.so
#7  0x00007fed85e32e72 in reco::parser::SingleInvoker::invoke(edm::ObjectWithDict const&, std::vector<edm::ObjectWithDict, std::allocator<edm::ObjectWithDict> >&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libCommonToolsUtils.so
#8  0x00007fed85e34fb3 in reco::parser::LazyInvoker::invokeLast(edm::ObjectWithDict const&, std::vector<edm::ObjectWithDict, std::allocator<edm::ObjectWithDict> >&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libCommonToolsUtils.so
#9  0x00007fed85e8a7a1 in reco::parser::ExpressionLazyVar::value(edm::ObjectWithDict const&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libCommonToolsUtils.so
#10 0x00007fed85e5e536 in reco::parser::ExpressionBinaryOperator<std::divides<double> >::value(edm::ObjectWithDict const&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libCommonToolsUtils.so
#11 0x00007fed5e9fabf1 in SimpleFlatTableProducerBase<reco::Candidate, edm::View<reco::Candidate> >::FuncVariable<StringObjectFunction<reco::Candidate, false>, float>::fill(std::vector<reco::Candidate const*, std::allocator<reco::Candidate const*> >, nanoaod::FlatTable&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_4_X_2018-10-29-1100/lib/slc6_amd64_gcc700/pluginPhysicsToolsNanoAODPlugins.so
#12 0x00007fed5e9f9ae7 in SimpleFlatTableProducer<reco::Candidate>::fillTable(edm::Event const&, edm::Handle<edm::View<reco::Candidate> > const&) const () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_4_X_2018-10-29-1100/lib/slc6_amd64_gcc700/pluginPhysicsToolsNanoAODPlugins.so
#13 0x00007fed5e9fbdfd in SimpleFlatTableProducerBase<reco::Candidate, edm::View<reco::Candidate> >::produce(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_4_X_2018-10-29-1100/lib/slc6_amd64_gcc700/pluginPhysicsToolsNanoAODPlugins.so
#14 0x00007fed94e1e763 in edm::stream::EDProducerAdaptorBase::doEvent(edm::EventPrincipal const&, edm::EventSetup const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) () from /cvmfs/cms-ib.cern.ch/nweek-02548/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-28-1100/lib/slc6_amd64_gcc700/libFWCoreFramework.so

Module: SimpleCandidateFlatTableProducer:photonTable (crashed)

I have no idea how the changes in this PR could lead to that.

[makortel]

@cmsbuild, please test

Let's try again.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31350/console Started: 2018/10/29 21:32

[cmsbuild]

+1
Tested at: 773b884
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25044/31350/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25044/31350/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@ssekmen could you please check and sign it in case?

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1