Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT menus used in HI relvals #25050

Merged
merged 1 commit into from Oct 30, 2018
Merged

Conversation

fabiocos
Copy link
Contributor

After the merge of the HI HLT menu for 2018 #25029 , as discussed with @Martin-Grunewald and @mandrenguyen
the HLT HI menu for 2015 HI relvals is moved to the @Fake;
the HLT HI menu for premix is temporarily moved to @Fake2 to avoid errors.

As soon as the new L1 menu is added to the GT (see #25029 (comment)) the 2018 HLT HI menus should be set to HIon.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

@lpernie @tocheng FYI, we need to follow up with the GT

@fabiocos
Copy link
Contributor Author

please test workflow 145.0,300.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31362/console Started: 2018/10/30 14:09

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25050/31362/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25050/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25050/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

@prebello @zhenhu @kpedro88 without this PR the workflows 300.X are failing now, and 145 is giving meaningless results. We will need to update the 2018 workflows as soon as the GT it updated with the latest L1 menu.

@fabiocos
Copy link
Contributor Author

+1

@prebello @zhenhu @kpedro88 please comment in case, or sign it for reference

@fabiocos
Copy link
Contributor Author

merge

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild cmsbuild merged commit 1ea7363 into cms-sw:master Oct 30, 2018
@zhenhu
Copy link
Contributor

zhenhu commented Oct 30, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@zhenhu
Copy link
Contributor

zhenhu commented Oct 30, 2018

@prebello @zhenhu @kpedro88 without this PR the workflows 300.X are failing now, and 145 is giving meaningless results. We will need to update the 2018 workflows as soon as the GT it updated with the latest L1 menu.

OK, we will update the workflows once the new GT is available

@fabiocos fabiocos deleted the fc-PyRelVal104X branch October 31, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants