Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HLT path selection and BaselineValidator module addition for HI (same as #2582 but for master) #25083

Merged
merged 3 commits into from Nov 2, 2018

Conversation

arossi83
Copy link
Contributor

@arossi83 arossi83 commented Nov 1, 2018

SiStrip Online DQM client setup for HI. All the changes affect only online (the SiStripBaselineValidator plugin is used only online).

Same as #25082 but for master

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The code-checks are being triggered in jenkins.

@arossi83
Copy link
Contributor Author

arossi83 commented Nov 1, 2018

Sorry, wrong reference number on title!

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/Integration
DQM/SiStripMonitorDigi

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@batinkov, @hdelanno, @makortel, @fioriNTU, @thomreis, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Pull request #25083 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31416/console Started: 2018/11/01 14:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Pull request #25083 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31418/console Started: 2018/11/01 15:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25083/31418/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992956
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 2, 2018

+1

@cmsbuild cmsbuild merged commit 39b8483 into cms-sw:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants