Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM/L1TEMU] Removing the condition for data/emul sizes being equal  - backport #25088

Conversation

vukasinmilosevic
Copy link
Contributor

@vukasinmilosevic vukasinmilosevic commented Nov 1, 2018

Removing the condition for data/emul sizes being equal in order to fill problematic sums histograms.
Backport of PR #25087

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for CMSSW_10_3_X.

It involves the following packages:

DQM/L1TMonitor

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31441/console Started: 2018/11/02 14:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25088/31441/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 398
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162504
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Pull request #25088 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31472/console Started: 2018/11/05 15:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Pull request #25088 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Pull request #25088 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@thomreis
Copy link
Contributor

thomreis commented Nov 9, 2018

Backport of #25087

@thomreis
Copy link
Contributor

thomreis commented Nov 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31555/console Started: 2018/11/09 15:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25088/31555/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3160863
  • DQMHistoTests: Total failures: 72
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160594
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c17a0e into cms-sw:CMSSW_10_3_X Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants